Skip to content

Added checking empty inputs in forward, fixed dumpToStream #26238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

Added checking empty inputs in forward, fixed dumpToStream #26238

wants to merge 54 commits into from

Conversation

@alexlyulkov
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

vpisarev and others added 30 commits August 22, 2024 01:13
@vpisarev
started porting the new experimental dnn engine into 5.x branch
4db83cb
@vpisarev
trying to fix some compile errors
834e932
@vpisarev
don't use C++11 incompatible std::string_view
4bff5c8
@vpisarev
ported some more code from the experimental engine to 5.x
f56dab0
@vpisarev
fixed a few compile warnings and errors
ac8a3cc
@vpisarev
duplicated onnx parser; fixed some more compile errors
0e50a66
@vpisarev
renamed cv::dnn::ArgInfo to cv::dnn::ArgData to reduce name conflicts…
ddd5353 
… with bindings generators that already defined and use ArgInfo
@asmorkalov
Hacked some of Python and Java bindings for DNN.
6d41567
@vpisarev
refactored ONNX parser in the new engine; not tested yet
8fbc69a
@vpisarev
resnet18 test seems to pass
925eaf3
@vpisarev
fixed a few bugs in the engine; still many tests fail
6051141
@vpisarev
added Reshape2 layer for better compliance with ONNX; fixed a few bug…
c1a5f73 
…s, eliminated a few dnn test failures
@vpisarev
implemented a bunch of layers (see opencv#26112)
ea533a0
@vpisarev
added new implementation of Split
09e1519
@vpisarev
fixed a few more bugs; the list of failed ONNX models was substantial…
8e4750e 
…ly reduced
@vpisarev
fixed bias handling in gemm
fe4c576
@vpisarev
switch back to the original ONNX parser if we have some unsupported (…
c8c8328 
…yet) layers in the model
@vpisarev
added shape inference w/o forward(). The number of test failures was …
6d087ed 
…reduced to 'just' 300.
@vpisarev
many bugs fixed. Now just 35 dnn tests fail on mac
2582143
@vpisarev
ok; just 9 dnn tests now fail on macos, 7 tests for einsum and 2 test…
bf1abca 
…s for deconvolution
@vpisarev
temporarily commented off a weird crash in keypoint model to see what…
158cdda 
… are the other test failures
@vpisarev
fixed deconvolution layer (and basically all other layers that may ne…
f1acb32 
…ed a temporary storage handled by the engine)
@vpisarev
dummy
090b67a
@vpisarev
einsum is working with layer tests
12f77d4
@vpisarev
working for all cases
00c1487
@vpisarev
fixed few more test failures in 'Release' mode
e1169f7
@vpisarev
fixed some more bugs in the engine, eliminated some of the remaining …
b60f73e 
…test failures
@vpisarev
continue eliminating test failures
0d46240
@vpisarev
continue eliminating test failures
152f172
@vpisarev
removed extra whitespaces
6001b39
vpisarev and others added 24 commits September 22, 2024 03:19
@vpisarev
fixed build errors (in Debug mode) and some test failures on Windows
b6d5d36
@vpisarev
fixed compile error when OpenVINO is enabled
864a70c
@Abdurrahheem @vpisarev
working with new graph engine
832455c
@Abdurrahheem @vpisarev
check if input shapes has changed
0153418
@Abdurrahheem @vpisarev
remove logs
12cddd9
@vpisarev
disabled 2 more Einsum tests
3b6e226
@vpisarev
fixed compile errors in DNN when CUDA is enabled.
d48d02f
@vpisarev
one more compile error fix in OpenCV+OpenVINO case
16d0165
@vpisarev
fixed iOS framework generation
a5653c9
@vpisarev
temporarily disabled OpenVINO detection
66e8831
@vpisarev
fixed Java test compile errors
0005b80
@vpisarev
hopefully, fixed CUDA tests failures; Deconvolution3D tests are disab…
caaebdb 
…led for now, because the new engine does not use CUDA yet and thus does not implement Deconvolution3D yet.
@vpisarev
temporarily disabled "no fallbacks" check in 'Fast Neural Style' (mos…
2f68d3e 
…aic-9.onnx) model test, since CUDA is not supported by the new engine yet
@asmorkalov
Added links for bugs and todos.
94922b8
@asmorkalov
Restored OpenVINO backend build.
b9dd083
@asmorkalov
Added implicit DNN engine selector to API.
3615d4a
@asmorkalov
Fixed dnn tests.
4a660fd
@asmorkalov
Added environment variable to force DNN engine.
3c557e3
@asmorkalov
Use customized pipelines for dnn engine branches.
12968da
@asmorkalov
Hacked Gemm layer to restore old parser support.
3b1aa1a
@Abdurrahheem @asmorkalov
new fix for einsum
5d2a9dc
@Abdurrahheem @asmorkalov
fix for padding. remove logic for handling 0d case in padding as it d…
1cf38b3 
…oes not make sence to make padding to scalors
@asmorkalov
Added error message when calling forward to specified layer in the ne…
48ccdfa 
…w dnn engine
Added checking empty inputs in forward, fixed dumpToStream
beb57b9
@asmorkalov
Copy link
Contributor

cherry-picked to the new_dnn_engine branch.

@asmorkalov asmorkalov closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexlyulkov @asmorkalov @vpisarev @Abdurrahheem