Skip to content

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Oct 2, 2024

  • OpenCV and OpenCV/Carotene implementations are derived from the same root and expect +- winsize border around the actual image and its derivatives. The functions get cv::Mat with the padded buffer like ROI.
  • OpenCV and OpenCV/Carotene Scharr derivatives have the same assumption in design and use +1 pixel border of the input image.
  • The border is already taken into account during pyramid allocation. It's filled by the image pixels, if available or with copyMakeBorder. CopyMakeBorder call has ticky logic and allows passing ROI of the original image as destination.  The function recognizes it and fills the border, but does not make a copy. So the current implementation is efficient in this term.

Relates to:

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Oct 2, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Oct 2, 2024
@asmorkalov asmorkalov requested a review from vpisarev October 2, 2024 09:39
@asmorkalov asmorkalov merged commit 73b3b24 into opencv:4.x Oct 2, 2024
29 of 30 checks passed
@asmorkalov asmorkalov mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants