Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test older versions of Go with toolchain=local #1133

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

sudo-bmitch
Copy link
Contributor

This prevents Go from doing an automatic upgrade, giving a better test of backwards compatibility. Related to #1114 (review)

Signed-off-by: Brandon Mitchell <git@bmitch.net>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on experiences in other projects

@sajayantony sajayantony merged commit 90f826d into opencontainers:main Nov 10, 2023
4 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-gotoolchain branch November 10, 2023 19:22
@sudo-bmitch sudo-bmitch mentioned this pull request Jan 11, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants