Update supported Go range to 1.19 - 1.21 #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
sajayantony
previously approved these changes
Sep 5, 2023
vbatts
dismissed
sajayantony’s stale review
The merge-base changed after approval.
sudo-bmitch
force-pushed
the
pr-go-1.21
branch
from
1da401b
to
2e4f535
Compare
tianon
reviewed
Sep 7, 2023
Previous supported range was 1.18 - 1.20. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-go-1.21
branch
from
2e4f535
to
c7a064f
Compare
tianon
requested changes
Sep 7, 2023
thaJeztah
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
LGTM
I'd personally also be "+1" on adding a GOTOOLCHAIN=local or GOTOOLCHAIN=path in the Makefile (which can be overridden by the user). I'm not a fan of Go's "schödingers version" making its way in my supply chain.
Great suggestion! I made that a separate PR, #1133. |
sajayantony
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the supported Go range to 1.19 - 1.21. The previous supported range was 1.18 - 1.20.