Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: output, storage, & naming #389

Open
4 tasks
gfudenberg opened this issue Sep 21, 2022 · 0 comments
Open
4 tasks

coverage: output, storage, & naming #389

gfudenberg opened this issue Sep 21, 2022 · 0 comments

Comments

@gfudenberg
Copy link
Member

gfudenberg commented Sep 21, 2022

  • outputting a 'track' (i.e. bintable+signal) instead of a numpy array for the user-facing function. The following lines can be migrated into api.coverage:
    coverage_table = clr.bins()[:][["chrom", "start", "end"]]
  • consider removing store inside cooler option.
    • For:
      • Other functions do not provide this, and it seems to be a legacy of copying the balance.py from cooler. This would streamline the API. (original commit: 4542ee4).
      • Modifies cooler, which is a potentially confusing side-effect of a function.
    • Against:
      • nice to store total cis inside the cooler. @Phlya
  • improve naming options for CLI & API.
  • decide if use_lock should be set to False or kept in arguments. Description in cooler: https://github.com/open2c/cooler/blob/987e87dd357c99a0a070b8a25cb7aaef86f1655c/cooler/tools.py#L16

continues discussion from PR #385

@gfudenberg gfudenberg changed the title coverage: storage & naming options coverage: output, storage, & naming Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant