Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] add new module go.opentelemetry.io/collector/client #9805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 21, 2024

Description:
Create a new go module go.opentelemetry.io/collector/client

Link to tracking Issue:
Fixes #9804

@atoulme atoulme requested a review from a team as a code owner March 21, 2024 06:40
@atoulme atoulme requested a review from Aneurysm9 March 21, 2024 06:40
@atoulme atoulme force-pushed the client_module branch 2 times, most recently from 08d91aa to 0f67eaa Compare March 21, 2024 06:49
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (d1e631b) to head (fc5cd5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9805   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         360      360           
  Lines       16642    16642           
=======================================
  Hits        15256    15256           
  Misses       1052     1052           
  Partials      334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member

Please consider a big refactor (including renaming probably) for this package before marking stable.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 22, 2024

Thanks Bogdan, captured this feedback in #9818

config/configgrpc/go.mod Outdated Show resolved Hide resolved
config/confighttp/go.mod Outdated Show resolved Hide resolved
exporter/otlpexporter/go.mod Outdated Show resolved Hide resolved
internal/e2e/go.mod Outdated Show resolved Hide resolved
receiver/otlpreceiver/go.mod Outdated Show resolved Hide resolved
client/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Apr 9, 2024
@atoulme atoulme force-pushed the client_module branch 5 times, most recently from b5b37ff to aa73da9 Compare April 21, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move client to a go module
3 participants