[cmd/mdatagen] Update the scope name generation method #9693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
madatagen-require-scope-name
branch
3 times, most recently
from
5d7f323
to
875ec98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9693 +/- ##
==========================================
- Coverage 90.93% 90.90% -0.04%
==========================================
Files 348 348
Lines 18379 18382 +3
==========================================
- Hits 16713 16710 -3
- Misses 1344 1348 +4
- Partials 322 324 +2 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Mar 5, 2024
dmitryax
force-pushed
the
madatagen-require-scope-name
branch
from
875ec98
to
d03583d
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
madatagen-require-scope-name
branch
from
d03583d
to
bc829a7
Compare
codeboten
approved these changes
Mar 5, 2024
Don't use hardcoded "go.opentelemetry.io/collector" prefix. Provide a way to specify the scope_name in metadat.yaml. If not provided, try to use the go package name.
dmitryax
force-pushed
the
madatagen-require-scope-name
branch
from
bc829a7
to
9c4d092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use hardcoded "go.opentelemetry.io/collector" prefix. Provide a way to specify the
scope_namein metadata.yaml. If not provided, try to use the go package name.Updates #9494