Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry base #2

Conversation

tuturiffic
Copy link

@tuturiffic tuturiffic commented Apr 18, 2024

Description: Minor updates to allow the receiver to build with newer (v0.97.0+) versions of opentelemetry-collector

Link to tracking Issue: Related to:

Testing: Most of the testing has been focused on being able to produce a build. Prior to these changes, the ocb was failing with, cannot use metadata.Type (untyped string constant "githubactions") as component.Type value in argument to receiver.NewFactory. After the changes, the ocb is successfully completing a build.

I also ran the standard set of Go tests. They are failing with the same error after these changes.

Documentation: The documentation changes are automatically generated via make generate. No manual documentation changes were made.

A simplified ocb configuration that can be used to test:

dist:
  name: otelcol-tuturiffic
  otelcol_version: "0.98.0"
  version: "gha"
  output_path: /tmp/otelcol

exporters:
  - gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.98.0

receivers:
  - gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.98.0
  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/githubactionsreceiver v0.0.0

replaces:
  - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/githubactionsreceiver => github.com/tuturiffic/opentelemetry-collector-contrib/receiver/githubactionsreceiver update-opentelemetry-base

@tuturiffic tuturiffic marked this pull request as ready for review April 18, 2024 16:34
@tuturiffic tuturiffic force-pushed the update-opentelemetry-base branch 2 times, most recently from 12a64e6 to 014586b Compare April 22, 2024 18:13
Newer releases of the collector require that components specify their
scope.
@@ -1,4 +1,5 @@
type: githubactions
scope_name: otelcol/githubactionsreceiver
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one line is effectively the only changed I've made at this point, everything else is auto-generated.

@tuturiffic
Copy link
Author

Recent changes appear to have made this unnecessary: I've been able to built a 0.98.0 distribution using the feat-add-githubactionseventreceiver branch directly.

@tuturiffic tuturiffic closed this Apr 26, 2024
@tuturiffic tuturiffic deleted the update-opentelemetry-base branch April 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant