Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog/connector] Create a simplified Trace to Trace connector #31026

Merged

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Feb 4, 2024

Description:

Datadog Connector is creating two instances of Trace Agent, one in the trace-to-metrics pipeline and another in the traces-to-traces pipeline. The PR separates the trace-to-trace connector, simplifying the logic, this avoid un-necessary serialization.

Link to tracking Issue:
#30828
#30487

Testing:

Documentation:

@github-actions github-actions bot requested a review from mx-psi February 4, 2024 21:08
@dineshg13 dineshg13 changed the title Dinesh.gurumurthy/fix connector Datadog connector Trace to Trace connector Feb 4, 2024
@dineshg13 dineshg13 changed the title Datadog connector Trace to Trace connector [datadog/connector] Create a simplified Trace to Trace connector Feb 4, 2024
@dineshg13 dineshg13 marked this pull request as ready for review February 4, 2024 21:21
@dineshg13 dineshg13 requested a review from a team as a code owner February 4, 2024 21:21
@dineshg13 dineshg13 marked this pull request as draft February 4, 2024 22:01
@dineshg13 dineshg13 marked this pull request as ready for review February 4, 2024 22:24
@mx-psi mx-psi requested a review from songy23 February 5, 2024 12:44
.chloggen/dinesh.gurumurthy_fix-connector.yaml Outdated Show resolved Hide resolved
connector/datadogconnector/connector.go Show resolved Hide resolved
connector/datadogconnector/connector.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from songy23 February 5, 2024 16:29
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit ae77a82 into open-telemetry:main Feb 5, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2024
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
…n-telemetry#31026)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Datadog Connector is creating two instances of Trace Agent, one in the
trace-to-metrics pipeline and another in the traces-to-traces pipeline.
The PR separates the trace-to-trace connector, simplifying the logic,
this avoid un-necessary serialization.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#30828

open-telemetry#30487

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants