[connector/datadog] fix lifecycle #30472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
fix_datadogconnector_start
branch
from
50c4a19
to
956ca0d
Compare
|
Depends on #30471 to be merged first. |
songy23
requested changes
Jan 12, 2024
atoulme
force-pushed
the
fix_datadogconnector_start
branch
3 times, most recently
from
52f7d4f
to
6116ed0
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
songy23
reviewed
Feb 5, 2024
|
Please rebase |
atoulme
force-pushed
the
fix_datadogconnector_start
branch
from
6116ed0
to
5d50391
Compare
atoulme
force-pushed
the
fix_datadogconnector_start
branch
2 times, most recently
from
ee33b99
to
33e5cde
Compare
|
@songy23 rebased |
songy23
reviewed
Feb 7, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
added
chore
Skip Changelog
|
@atoulme can you please rebase? |
…sent; make shutdown work even if start was not called
atoulme
force-pushed
the
fix_datadogconnector_start
branch
from
3b655ee
to
e577758
Compare
|
Done, will ping once tests complete if they pass. |
|
Tests didn't pass. It looks like the "trace to metrics" path still fails. @songy23 what do you think? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mackjmr can you take a look? |
|
Closing in favor of #31811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix start logic to start if tracesConsumer is present; make shutdown work even if start was not called
Related issue
Fixes #30487