Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ChartJs: Properly destroy chartJs object on component wrapper d… #4137

Closed
wants to merge 1 commit into from

Commits on May 3, 2024

  1. [FIX] ChartJs: Properly destroy chartJs object on component wrapper d…

    …eletion
    
    How to reproduce:
    
    - Make a chartjs chart (line/bar/pie)
    - Mousedown on a datapoint/bar/part of the pie
    - move your mouse
    - mouseup (lift your finger) while still moving your mouse
    -> crash
    
    We were not properly destroying the chart js item and their linked
    eventListeners persisted. Specifically, the eventHandler of the tooltip
    plugin would still try to handle the mousemove event while its internal
    state was partially invalidated.
    
    Task: 3777754
    rrahir authored and LucasLefevre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2c130d8 View commit details
    Browse the repository at this point in the history