[FIX] ChartJs: Properly destroy chartJs object on component wrapper d… #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrahir
force-pushed
the
saas-17.1-fix-chart-error-rar
branch
from
5a6a703
to
c94b60e
Compare
hokolomopo
reviewed
Apr 29, 2024
Comment on lines
1226
to
1235
| await nextTick(); | ||
| await nextTick(); | ||
| expect(spyDelete).toHaveBeenCalled(); |
There was a problem hiding this comment.
Do you know why we need 2 nextTicks ?
There was a problem hiding this comment.
Looks like one is enough
LucasLefevre
force-pushed
the
saas-17.1-fix-chart-error-rar
branch
from
c94b60e
to
63cec81
Compare
…eletion How to reproduce: - Make a chartjs chart (line/bar/pie) - Mousedown on a datapoint/bar/part of the pie - move your mouse - mouseup (lift your finger) while still moving your mouse -> crash We were not properly destroying the chart js item and their linked eventListeners persisted. Specifically, the eventHandler of the tooltip plugin would still try to handle the mousemove event while its internal state was partially invalidated. Task: 3777754
LucasLefevre
force-pushed
the
saas-17.1-fix-chart-error-rar
branch
from
63cec81
to
2c130d8
Compare
|
robodoo r+ (rebased and resolved conflicts) |
robodoo
pushed a commit
that referenced
this pull request
May 3, 2024
…eletion How to reproduce: - Make a chartjs chart (line/bar/pie) - Mousedown on a datapoint/bar/part of the pie - move your mouse - mouseup (lift your finger) while still moving your mouse -> crash We were not properly destroying the chart js item and their linked eventListeners persisted. Specifically, the eventHandler of the tooltip plugin would still try to handle the mousemove event while its internal state was partially invalidated. closes #4137 Task: 3777754 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eletion
How to reproduce:
We were not properly destroying the chart js item and their linked eventListeners persisted. Specifically, the eventHandler of the tooltip plugin would still try to handle the mousemove event while its internal state was partially invalidated.
Task: 3777754
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist