Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] electronic_store: Electronic Store #64

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[ADD] electronic_store: Electronic Store #64

wants to merge 1 commit into from
+3,149 −0

Conversation

dhrs-odoo
Copy link
Contributor

@dhrs-odoo dhrs-odoo commented Dec 18, 2023 •
edited

This module provides essential features to manage an electronic store.
It includes product categories, products, sales orders, and more for electronic products.

Task - 3460473

@hamo-odoo hamo-odoo changed the base branch from 17.0 to master December 20, 2023 04:59
@hamo-odoo hamo-odoo changed the base branch from master to 17.0 December 20, 2023 05:01
prra-odoo
prra-odoo requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@prra-odoo prra-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
Posted my first review, more changes yet to come
Please do the needful changes!

electronic_store/data/helpdesk_config.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_model_fields.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_model_fields.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_model_fields.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_model_fields.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
prra-odoo
prra-odoo requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@prra-odoo prra-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
Posted my 2nd review also
Please make these changes as well

electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/helpdesk_ticket.xml Outdated Show resolved Hide resolved
electronic_store/demo/purchase_order.xml Outdated Show resolved Hide resolved
electronic_store/demo/res_partner.xml Outdated Show resolved Hide resolved
electronic_store/demo/res_partner.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Show resolved Hide resolved
@assi-odoo assi-odoo force-pushed the master-electronic_store-gusi branch 7 times, most recently from 1ea024b to b03a2a7 Compare January 11, 2024 06:39
prra-odoo
prra-odoo requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@prra-odoo prra-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @assi-odoo

Some final remarks, afterwards good to go from my side!
Mainly fix formatting and unnecessary spacing and reduce LOC from the website_views.xml

Thanks!

electronic_store/data/ir_model_fields.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_ui_view.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_ui_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
prra-odoo
prra-odoo requested changes Jan 11, 2024
View reviewed changes
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
@assi-odoo assi-odoo force-pushed the master-electronic_store-gusi branch 4 times, most recently from 331b15c to 4bc5e18 Compare January 15, 2024 13:13
@prra-odoo prra-odoo force-pushed the master-electronic_store-gusi branch 3 times, most recently from 48ff75d to ec6ce71 Compare January 23, 2024 06:00
@prra-odoo prra-odoo changed the title Master electronic store gusi [ADD] electronic_store: Electronic Store Jan 23, 2024
@paso-odoo paso-odoo marked this pull request as ready for review January 29, 2024 10:36
paso-odoo
paso-odoo requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@paso-odoo paso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prra-odoo @assi-odoo

Thanks for working on this!
Here, are some quick reviews for this PR. Please apply them several times if needed!

Cheers!

electronic_store/data/documents_folder.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_actions_act_window.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_actions_act_window.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_ui_view.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_model_access.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_theme_apply.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_theme_apply.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/static/src/binary/ir_attachment/471-1.jpg Outdated Show resolved Hide resolved
@assi-odoo assi-odoo force-pushed the master-electronic_store-gusi branch 2 times, most recently from 3b0672b to 99d9701 Compare February 9, 2024 07:22
@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch 2 times, most recently from ce028c5 to b15286a Compare February 20, 2024 10:21
@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch from 159e192 to 667e27c Compare March 6, 2024 06:14
@dhrs-odoo
Copy link
Contributor Author

Hello @paso-odoo
Given changes has been implemented
Thank You 😇

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch from 667e27c to f6a3ef6 Compare March 19, 2024 09:29
@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch 3 times, most recently from eb0b7ef to ac347c5 Compare April 5, 2024 12:02
vava-odoo
vava-odoo requested changes Apr 10, 2024
View reviewed changes
electronic_store/data/product_template.xml Outdated Show resolved Hide resolved
electronic_store/__manifest__.py Outdated Show resolved Hide resolved
electronic_store/data/account_analytic_account.xml Outdated Show resolved Hide resolved
electronic_store/data/account_analytic_plan.xml Outdated Show resolved Hide resolved
electronic_store/data/base_automation.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Show resolved Hide resolved
@vava-odoo vava-odoo dismissed paso-odoo’s stale review April 10, 2024 13:52

All remarks were taken into account

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch 5 times, most recently from 911ef23 to 17b24c9 Compare April 17, 2024 08:34
@dhrs-odoo
Copy link
Contributor Author

Hello @vava-odoo
I have implemented the suggested changes,
Kindly have a look at it once you are free
Thank You 😇

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch 3 times, most recently from ab92b53 to b742476 Compare April 18, 2024 10:58
vava-odoo
vava-odoo requested changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhrs-odoo
Thanks for the update. I listed some other comments, before final validation.
Cheers!

electronic_store/data/product_product.xml Show resolved Hide resolved
electronic_store/__manifest__.py Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/ir_ui_view.xml Outdated Show resolved Hide resolved
electronic_store/data/product_product.xml Outdated Show resolved Hide resolved
electronic_store/data/res_config_settings.xml Outdated Show resolved Hide resolved
@dhrs-odoo
Copy link
Contributor Author

Hello @vava-odoo
I have updated the changes as per your suggestions
Kindly have a look at it
Thank You and Have a great day ahead 😇

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch 3 times, most recently from 850bba7 to 19be013 Compare April 26, 2024 07:13
vava-odoo
vava-odoo requested changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhrs-odoo
Thanks for the update. Could you have a look at the following comments?
Cheers!

electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/demo/website_view.xml Outdated Show resolved Hide resolved
electronic_store/data/project_project.xml Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
electronic_store/data/knowledge_article.xml Outdated Show resolved Hide resolved
@dhrs-odoo
Copy link
Contributor Author

Hello @vava-odoo
I have incorporated your comments
kindly have a look at it once you are free
Thank You and Have a great day ahead 😇

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch from f8021f5 to 15f0bc6 Compare May 10, 2024 06:13
@dhrs-odoo
Copy link
Contributor Author

Hello @vava-odoo
I have incorporated the suggested changes
kindly have a look at it once you are free
Thank You 😇

@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch from 15f0bc6 to 9da78d5 Compare May 10, 2024 12:13
@dhrs-odoo
[ADD] electronic_store: Electronic Store
170a592 
This module provides essential features to manage an electronic store.
It includes product categories, products, sales orders, and more for electronic
products.

Task - 3460473
@dhrs-odoo dhrs-odoo force-pushed the master-electronic_store-gusi branch from 9da78d5 to 170a592 Compare May 10, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prra-odoo prra-odoo prra-odoo approved these changes

@vava-odoo vava-odoo vava-odoo approved these changes

@paso-odoo paso-odoo paso-odoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dhrs-odoo @paso-odoo @prra-odoo @vava-odoo