[IMP] inventory: multi-step label section #9007
Conversation
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
6c4850a
to
d8ea737
Compare
|
Hello @ksc-odoo ! This PR is ready for your first round of peer review (: It's a small feature update |
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
d8ea737
to
e830c51
Compare
There was a problem hiding this comment.
@Felicious -- just finished my Peer Review on this. Looks good to me! Only a handful of suggestions that require your attention. once you implement the necessary changes, feel free to move it to the next round. Thanks! 👍
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
53ee438
to
71c9f0f
Compare
Felicious
requested review from
a team and
StraubCreative
and removed request for
a team
|
Hello @StraubCreative, this ~50 line PR is ready for your final review! :D Tenks for your help |
There was a problem hiding this comment.
Hi @Felicious
Looks good to me!
I just had one comment for you to consider, otherwise this is ready for @samueljlieber when you're ready 🙂
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Show resolved
Hide resolved
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
71c9f0f
to
36ab350
Compare
|
Hey @samueljlieber ! This PR is ready for your technical review, when you get the chance (: |
There was a problem hiding this comment.
Hi @Felicious! Nice work on this PR. Your changes looks great to me, and Im approving and delegating merge to you, with one small fix. Thank you! 😊
..
@robodoo delegate=Felicious
...tions/inventory_and_mrp/inventory/shipping_receiving/advanced_operations_shipping/labels.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
36ab350
to
82f2d13
Compare
|
@robodoo r+ |
closes #9007 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
|
@Felicious staging failed: ci/runbot on 497f080f59853ce290d1164a4b91f3b4e536b13f (view more at https://runbot.odoo.com/runbot/build/62083167) |
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Felicious
force-pushed
the
17.0-inventory-multi-step-label-feku
branch
from
82f2d13
to
4a47580
Compare
|
@robodoo r+ |
closes #9007 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
|
@Felicious staging failed: ci/runbot on 6e8fb8dd9b685d84d97f1be3f27288fec4785876 (view more at https://runbot.odoo.com/runbot/build/62083483) |
|
robodoo retry |
closes #9007 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Summary
Fwport: yes!
Task