Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] events: adding create events doc #8929

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented Apr 23, 2024

PROJECT TASK: https://www.odoo.com/web#id=3888717&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

This brand new PR walks the user through how to create an event with Odoo Events, and will take a in-depth detailed look at all the fields, tabs, elements, and options involved in doing so.

@ksc-odoo ksc-odoo self-assigned this Apr 23, 2024
@ksc-odoo ksc-odoo marked this pull request as draft April 23, 2024 14:26
@robodoo
Copy link
Collaborator

robodoo commented Apr 23, 2024

@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch 2 times, most recently from af16dd2 to 9f05914 Compare April 24, 2024 16:15
@ksc-odoo ksc-odoo marked this pull request as ready for review April 24, 2024 16:16
@C3POdoo C3POdoo requested a review from a team April 24, 2024 16:17
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch from 9f05914 to 11553a3 Compare April 24, 2024 16:24
@ksc-odoo
Copy link
Contributor Author

Alrighty, @tiku-odoo this is ready for a Peer Review from you. Thanks!

Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo

This is a great addition to the events documentation. Awesome job on really going through the event form. I've made some optional functional questions and made corrections to one or two misspellings (very minor). Feel free to implement the suggestions as you see fit. I'm approving this doc to move forward now.

Thanks,
Tim 👍

content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch from 11553a3 to 44625fd Compare April 29, 2024 17:50
@ksc-odoo
Copy link
Contributor Author

Thank you for the always helpful feedback, @tiku-odoo -- I made all your suggested edits, and believe this is now ready for a Final Review @StraubCreative -- whenever you get a chance. Thanks! 👍

@ksc-odoo ksc-odoo requested review from StraubCreative and removed request for a team April 29, 2024 17:53
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch from 44625fd to 4d1bf93 Compare April 30, 2024 12:55
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo

Awesome doc! So glad we'll have this in our repository 💪

Approving with comments. I have a number of items here, for you to consider, to help add depth or supporting context to the various features and fields of the event form as well as the larger event creation process.

  • Please minimally address the items below labeled: ❗ Necessary change
  • For everything else, I would consider addressing on a new PR (for an additional 2-3 pts 😉) since publishing this doc live is more important (and useful!) to our users than it would be sitting in review.

I hope you find the comments to be useful and informative in expanding the documentation. Please let me know if you have any questions.

Otherwise, great job and see you on the next review!

content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
Comment on lines +40 to +44
At the top of the event form are a series of smart buttons related to various event metrics, which
will autopopulate with pertinent data once attendees begin to register, booths and sponsors sign on
for the event, the event takes place, and so on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is misleading, albeit unintentionally, in that, the smart buttons are primarily used as logistical portals to perform actions for the event in specific ways for the organizer(s), and are secondarily useful as numeric displays.

The same way you might point to a Delivery or Manufacturing smart button on a Sales Order— it's not just to say "I have 1 Delivery Order," it's instead to invite action around specific and necessary activities through those buttons. The numeric value is surface-level, whereas the activities before and after, surrounding the smart buttons, matter more.

Further, when those figures are displayed, you can still click into the button and perform a variety of useful actions afterwards, specifically around reporting.

In this way, consider more strongly emphasizing the utility of the buttons so we communicate their operational relevance for the user.

content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch 3 times, most recently from 14f996e to 37dea15 Compare May 14, 2024 17:35
@ksc-odoo
Copy link
Contributor Author

Thanks for the in-depth feedback, @StraubCreative . I made all the necessary modifications, and some other supplemental ones along the way, and believe this one is now ready for Tech Review @samueljlieber 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Thank you for all your hard work on this brand new Events doc! I think this new doc adds a lot of quality information for creating events. I also agree with ZST that there are a bunch of avenues that open up with publishing this doc, that can be documented in the near future!

I have a bunch of suggestions for you (sorry 😅) hopefully you find them constructive! Please let me know your thoughts on any that you may want to discuss. Tag me for another quick look after you have had a chance to work through these.

Thanks for your continued hard work here, almost there! 🙂

p.s. Please let me know if it would be easier for you if I made a second commit to your PR with all these changes (as I have them made locally)

content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/create_events.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch from 37dea15 to 389b981 Compare May 15, 2024 17:51
@ksc-odoo ksc-odoo force-pushed the 17.0-events-add-create-event-doc-ksc branch from 389b981 to c22670d Compare May 15, 2024 17:56
@ksc-odoo
Copy link
Contributor Author

Thanks for the incredibly helpful, super-detailed feedback, @samueljlieber -- I made ALL the suggested edits you left, and believe it's ready for another look from you, whenever you get a chance. Thanks! 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @ksc-odoo! Nice work 👍
.....
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants