Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] events: event templates doc #9076

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented Apr 30, 2024

PROJECT TASK: https://www.odoo.com/web#id=3901937&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

This BRAND NEW PR will focus on everything the user should know about Event Templates

  • new workflow
  • new screenshots
  • added to toctree

This PR is also adhering to some recent feedback I've received about getting too granular with explanations, so I am attempting to be more concise with the instructions presented throughout.

Also, this PR should be merged/published AFTER #8929 , because there is a lot of referenced links used in this PR, which will likely result in continued build errors until that create_events doc is published.

@ksc-odoo ksc-odoo added the 5 label Apr 30, 2024
@ksc-odoo ksc-odoo self-assigned this Apr 30, 2024
@ksc-odoo ksc-odoo marked this pull request as draft April 30, 2024 13:04
@robodoo
Copy link
Collaborator

robodoo commented Apr 30, 2024

@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-templates-ksc branch from dca6a45 to 202c9a4 Compare April 30, 2024 17:07
@ksc-odoo ksc-odoo marked this pull request as ready for review April 30, 2024 17:08
@C3POdoo C3POdoo requested a review from a team April 30, 2024 17:09
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-templates-ksc branch from 202c9a4 to a7713b1 Compare April 30, 2024 17:13
@ksc-odoo
Copy link
Contributor Author

Alrighty, @Felicious -- this one is ready for a Peer Review whenever you get a chance. As mentioned in the initial description of this PR, there are build errors because a different PR needs to be merged/published first (and its referenced in this PR)... but other than that, it should be good to go 👍

@ksc-odoo ksc-odoo requested review from Felicious and removed request for a team April 30, 2024 17:19
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this document, @ksc-odoo!

It provides a comprehensive overview of the Booth tab, which hasn't been covered in the Events documentation before. I really appreciate how you've kept the document concise by linking to relevant resources, ensuring we avoid any duplicate information across our docs.

I just had some minor rewording changes for you to consider, so after taking a look at those, feel free to move this onto the next stage of review!

content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-templates-ksc branch 2 times, most recently from 092a8ac to 6022bb6 Compare May 17, 2024 21:02
@ksc-odoo
Copy link
Contributor Author

Thanks for the super helpful feedback, @Felicious -- just implemented all your changes, and believe this one is now ready for Final Review, @StraubCreative 👍

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo
I thought this was well-written and pleasant to read, nice job 👍
There's only a few comments for you below but they're all high-level and optional, for you to consider. In any case, approving for the next round, so feel free to tag SALI when you're ready, thanks!

content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-templates-ksc branch 4 times, most recently from a9de63b to 11a0605 Compare May 24, 2024 18:47
@ksc-odoo
Copy link
Contributor Author

Thanks for the helpful feedback, @StraubCreative -- I implemented all your suggestions, and believe this is now ready for Tech Review, @samueljlieber
(I'm having a consistent build error that I am hoping you can help me fix 🙏 )

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Nice job on this brand new Events doc on Event Templates. I think you covered this feature nicely :)

I am approving with some corrections and suggestions, please make sure to compress the images before merge! Thank you for your hard work on this!
.....
@robodoo delegate=ksc-odoo

content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_templates.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-templates-ksc branch from 11a0605 to 0c20f3f Compare May 28, 2024 18:34
@ksc-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo robodoo closed this in fb2f1d5 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants