Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the toplevel buttons to the bottom-right #409

Merged
merged 2 commits into from Sep 15, 2021
Merged

Move the toplevel buttons to the bottom-right #409

merged 2 commits into from Sep 15, 2021

Conversation

AltGr
Copy link
Collaborator

@AltGr AltGr commented Jul 30, 2021 •
edited

Another proposition to fix for #400 and #202

@AltGr
Copy link
Collaborator Author

AltGr commented Jul 30, 2021

image

@AltGr
Revert "Merge pull request ocaml-sf#261 from beobillly/placement_topl…
16d2d12 
…evel_buttons"

This reverts commit 3972fe1, reversing
changes made to d5c078c.
@AltGr
Fix for ocaml-sf#400 and ocaml-sf#202
d61e7c0 
* move buttons to the right so that they are less easy to misclick
* reverse order so that "eval phrase" is first
@erikmd erikmd added kind: enhancement Enhancement to an existing user-facing feature. part: CSS labels Sep 15, 2021
erikmd
erikmd approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AltGr! this new placement look very fine to me…
(good idea BTW, to have first reverted the merge of PR #261)
If @yurug doesn't object, I propose we merge this very soon (today)

@erikmd erikmd self-assigned this Sep 15, 2021
@erikmd erikmd merged commit 90066d0 into ocaml-sf:master Sep 15, 2021
@erikmd erikmd mentioned this pull request Sep 15, 2021
Closed
15 tasks
@erikmd erikmd added this to the learn-ocaml 0.13 milestone Sep 15, 2021
@erikmd erikmd mentioned this pull request Sep 15, 2021
Closed
@erikmd erikmd mentioned this pull request Oct 5, 2021
Merged
@proofbot proofbot mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmd erikmd erikmd approved these changes

Assignees

@erikmd erikmd

Labels
kind: enhancement Enhancement to an existing user-facing feature. part: CSS
Projects
None yet
Milestone
learn-ocaml 0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AltGr @erikmd