Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement of the "Eval phrase" button #400

Closed
EmileRolley opened this issue Jun 22, 2021 · 3 comments
Closed

Placement of the "Eval phrase" button #400

EmileRolley opened this issue Jun 22, 2021 · 3 comments
Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: question part: CSS

Comments

@EmileRolley
Copy link
Collaborator

I think it would be nice to have the Eval Phrase button on the right of the text box instead of in the top right with everything else. That would make it more clear what it actually does. It's not very intuitive to have it so far away from the text field.

Originally posted by @adhameer in #202 (comment)
@EmileRolley EmileRolley added kind: enhancement Enhancement to an existing user-facing feature. part: CSS labels Jun 22, 2021
@EmileRolley EmileRolley reopened this Jun 22, 2021
@EmileRolley EmileRolley changed the title Placement of the eval phrase button Placement of the "Eval phrase" button Jun 22, 2021
@AltGr
Copy link
Collaborator

AltGr commented Jul 23, 2021

Indeed I can see the original issue but I am not convinced by the accepted solution in #261: in particular, the buttons should have a dedicated space and not overlap on top of the toplevel text.

@EmileRolley
Copy link
Collaborator Author

EmileRolley commented Jul 23, 2021 •
edited

So, do you want to extend the scope of this issue to: Redesign the toplevel UI? Or, opening a new one referencing this issue?

AltGr added a commit to AltGr/learn-ocaml that referenced this issue Jul 30, 2021
@AltGr
Fix for ocaml-sf#400 and ocaml-sf#202
af10dd8 
* move buttons to the right so that they are less easy to misclick
* reverse order so that "eval phrase" is first
@AltGr AltGr mentioned this issue Jul 30, 2021
Merged
AltGr added a commit to AltGr/learn-ocaml that referenced this issue Jul 30, 2021
@AltGr
Fix for ocaml-sf#400 and ocaml-sf#202
d61e7c0 
* move buttons to the right so that they are less easy to misclick
* reverse order so that "eval phrase" is first
@erikmd
Copy link
Member

erikmd commented Sep 15, 2021

It seems the issue was not automatically closed by merging #409 (so let's do that manually :)

@erikmd erikmd closed this as completed Sep 15, 2021
EmileRolley pushed a commit to EmileRolley/learn-ocaml that referenced this issue Sep 16, 2021
@AltGr @EmileRolley
Fix for ocaml-sf#400 and ocaml-sf#202
9c8bfdf 
* move buttons to the right so that they are less easy to misclick
* reverse order so that "eval phrase" is first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: question part: CSS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AltGr @erikmd @EmileRolley