Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPE and purl regex #711

Merged

Conversation

tschmidtb51
Copy link
Contributor

- addresses parts of oasis-tcs#693, oasis-tcs#710
- correct pattern to `^((CPE2.3)|(CPE2.2))$`
- add additional `\\` to escape previously unescaped `/`
- addresses parts of oasis-tcs#693
- correct parsing of CPE 2.3 Dictionary (to also capture endings `">` instead of just `"/>`)
- addresses parts of oasis-tcs#693
- add new local test cases
- adopt test script
- addresses parts of oasis-tcs#710
- add additional `\\` to escape previously unescaped `/`
@tschmidtb51 tschmidtb51 added the csaf 2.1 csaf 2.1 work label Mar 27, 2024
@tschmidtb51 tschmidtb51 self-assigned this Mar 27, 2024
@tschmidtb51
Copy link
Contributor Author

@ctron Please review

- addresses parts of oasis-tcs#693
- add conversion rule
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@santosomar santosomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating these and for following up on the other PR.

@santosomar
Copy link
Contributor

Since this is correcting a bug, there is no need to bring it into voting. I will merge the PR now.

@santosomar santosomar merged commit bc6c0f4 into oasis-tcs:editor-revision-2024-03-27 Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf 2.1 csaf 2.1 work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants