fix: escape slashes in regular expressions #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like some regexp engines do have an issue with slashes not being escaped. This change fixes this by also escaping slashes.
|
Thank you so much for catching this and suggesting the fix. We will quickly discuss during the TC meeting and then merge the changes. Thank you again! |
santosomar
approved these changes
Mar 27, 2024
tschmidtb51
added a commit
to tschmidtb51/csaf
that referenced
this pull request
Mar 27, 2024
- addresses parts of oasis-tcs#693, oasis-tcs#710 - correct pattern to `^((CPE2.3)|(CPE2.2))$` - add additional `\\` to escape previously unescaped `/`
|
The related issue is #693. I'll provide a PR which addresses the suggestion completely. |
tschmidtb51
added a commit
to tschmidtb51/csaf
that referenced
this pull request
Mar 27, 2024
- addresses parts of oasis-tcs#710 - add additional `\\` to escape previously unescaped `/`
Merged
tschmidtb51
added a commit
to tschmidtb51/csaf
that referenced
this pull request
Mar 27, 2024
- addresses parts of oasis-tcs#710 - backport of 61e78c8 - correct parsing of CPE 2.3 Dictionary (to also capture endings `">` instead of just `"/>`)
Merged
|
Superseded by #711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some regexp engines do have an issue with slashes not being escaped. This change fixes this by also escaping slashes.