Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isDevToolsOpen to public interface #4751

Closed
wants to merge 1 commit into from
Closed

Add isDevToolsOpen to public interface #4751

wants to merge 1 commit into from

Conversation

zenoamaro
Copy link

isDevToolsOpen is not present on a Window object since at least 0.13 (see, eg., #4487).

This patch adds isDevToolsOpen to a few places where it is missing.

You can test presence (or thereof) with a simple app:

<script>
  alert(nw.Window.get().showDevTools); // function...
  alert(nw.Window.get().isDevToolsOpen); // undefined
</script>

Issue was first encountered while testing on 0.14.0-sdk-1 from npm after upgrading from ^0.12.

@rogerwang
Copy link
Member

Thanks but it should come with an implementation.

@rogerwang rogerwang closed this May 3, 2016
@zenoamaro
Copy link
Author

Thanks for checking out.

As far as I can see, the implementation is there already, just not exported to the public interface, hence the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants