Added isDevToolsOpen interface and missing impl.

[zenoamaro]

[Follow up from #4751]

isDevToolsOpen is not present on a Window object since at least 0.13 (see, eg., #4487).

This patch

• adds isDevToolsOpen interface where it was missing;
• adds a concrete implementation;
• fixes a few consistency issues.

You can test presence (or thereof) with a simple app:

<script>
  alert(nw.Window.get().showDevTools); // function...
  alert(nw.Window.get().isDevToolsOpen); // undefined
</script>

Issue was first encountered while testing on 0.14.0-sdk-1 from npm after upgrading from ^0.12.

[rogerwang]

We don't use src/api/window/window.cc src/api/window_bindings.js and src/nw_shell.h now.

[zenoamaro]

Thanks for the information.

Is this change related to nw15rc? I tried to rebase this patch on top on branch nw15 and it rebased cleanly, so it is not clear to me if I should restrict implementation to some of these files. I made sure to cover every source that was also covered by CloseDevTools and related.

Could you share some pointers about this migration, so that I can update the patch? Should I simply discard changes involving those sources?

Thanks for the incredible work,

[rogerwang]

We changed the architecture of API binding. The new one is https://github.com/nwjs/nw.js/blob/nw19/src/api/nw_window_api.cc
https://github.com/nwjs/nw.js/blob/nw19/src/resources/api_nw_window.js

So closing this PR.