Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong helper function imported in SE(3) exercises #36

Open
amoreau96 opened this issue May 26, 2022 · 1 comment
Open

Wrong helper function imported in SE(3) exercises #36

amoreau96 opened this issue May 26, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@amoreau96
Copy link

In SE(3) exercises, the imported helper_func.py is from the transformation_2d lessons.

I assume this is because the students might want to use some of its functions for the first exercise. Won't it crash when you try to run the exercises from the student's zip file, since the 2D helper_func.py isn't included in the zip file?

Apologies in advance if this is the desired behavior.

@pomerlef pomerlef added the bug Something isn't working label May 27, 2022
@pomerlef
Copy link
Contributor

Thanks, we will investigate that. It could be from a wrong copy-paste.

I would add that, having multiple files named helper_func.py is not the best for maintenance. We should be more explicit for these file names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants