Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of property validation message for typedInput #4449

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

GogoVega
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This PR adds the validation message (tooltip) to inputs built with typedInput.
This is an extension of the #3438

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@GogoVega
Copy link
Contributor Author

Hi @knolleary,
I may have a reliable solution to add the validation message for the typeField.
If the type of typedInput is incorrect, the field turns red and a tooltip displays the validation message.
Are you interested in this?

@knolleary
Copy link
Member

In general I'd expect the typeField to be managed by the node and not something the user can get 'wrong'.

But if you have a use case for it, and it's something that fits with what we already do, then please do propose something.

@GogoVega
Copy link
Contributor Author

The use case that I see would be a type that no longer exists or that has been renamed or deactivated...
This allows to show where the property with a validation error is.

This type change can be managed by the node but requires deployment, which is why a message warning the user that he must (or will) do something is preferable.

Thanks, I make a new PR?

@knolleary knolleary added this to the 4.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants