Add abstract base class syntax to tokenize/api.py #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is Python 2 - only syntax for abc, in Python 3 it does nothing. Check six.with_metaclass or six.add_metaclass (https://pythonhosted.org/six/#six.with_metaclass) |
|
@kmike Ah good catch! Fixing this... |
|
Thanks @mrecachinas, @kmike |
|
@stevenbird Ready for merge or should I add any other changes? |
stevenbird
added a commit
that referenced
this pull request
Jan 4, 2016
Add abstract base class syntax to tokenize/api.py
|
Thanks @mrecachinas. Sorry for the delay. Looks like we have a model that could be applied across the toolkit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1130.