server: Respond WS text request as text as well #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Make the `WS` server to respond to requests in text when they arrive in text format instead of always replying in binary.
jsdanielh
force-pushed
the
jsdanielh/text-ws
branch
from
280b1ad
to
9625cfa
Compare
hrxi
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks good to me. Maybe mention in the description that it fixes nimiq/core-rs-albatross#2226, so that it'll auto-close.
Mmm, we would have to update the dependency first in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
wsserver to respond to requests in text when they arrive in text format instead of always replying in binary.