server: Do not echo the close message #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hrxi
reviewed
Feb 27, 2024
Change the `ws` upgrade to not echo the close message since that is actually not permitted by `warp`. Instead just close the `Sink` for a proper clean up.
jsdanielh
force-pushed
the
jsdanielh/close-sink
branch
from
06f490b
to
27f19e4
Compare
|
This fixes the hanging of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
wsupgrade to not echo the close message since that is actually not permitted bywarp. Instead just close theSinkfor a proper clean up.Depends on #20.