Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix starfusion download output for gtf to refflat #463

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

dodslaser
Copy link

Make output.chrgtf from STARFUSION_DOWNLOAD a tuple for compatibility with GTF_TO_REFFLAT.

This fixes reference generation when --starfusion_build is false.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

Copy link

github-actions bot commented Jan 31, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit 39f066c

+| ✅ 162 tests passed       |+
!| ❗   2 tests had warnings |!
-| ❌   8 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/WorkflowRnafusion.groovy
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - pyproject.toml does not match the template

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • pipeline_todos - TODO string in WorkflowRnafusion.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-29 12:11:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants