Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-test for pilon #5293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

thanhleviet
Copy link
Contributor

replaced pytest with nf-test for pilon

@thanhleviet thanhleviet requested review from scorreard and a team as code owners March 19, 2024 19:25
@thanhleviet thanhleviet requested review from SPPearce and removed request for a team March 19, 2024 19:25
@telatin
Copy link
Contributor

telatin commented Mar 19, 2024

I think pytest should be removed now. Quoting J F Yates:

Yes, if you add nf-test, remove pytest. The -m8grate-pytest` flag should do that for you if you do it via Nf-core tools

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems fine, it just needs a better name. More tests could be useful if possible.

tag "pilon"


test("Test PILON") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change test name to something more specific, there is no standard (yet) but something like pilon - bam - paired should do

)
}

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the module has multiple modes, is it possible to add tests for the others? And a stub test as well, although I see the module currently lacks a stub

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some new info on test files

process {
"""
input[0] = [ [ id:'test', single_end:false ], // meta map
file(params.test_data['homo_sapiens']['genome']['genome_fasta'], checkIfExists: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the new guideline is to use URLs instead of the test_data object, so please change the tests accordingly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just started so can you point to the guidelines? I found some info (but not technical details) here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to #5281 for an example, I believe it's not documented yet, but the documentation team is working on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to the test-data path is not required currently, just optional.

@SPPearce
Copy link
Contributor

Please add a stub and test for the stub as mentioned by @itrujnara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

4 participants