New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-test for pilon #5293
base: master
Are you sure you want to change the base?
nf-test for pilon #5293
Conversation
I think
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test seems fine, it just needs a better name. More tests could be useful if possible.
tag "pilon" | ||
|
||
|
||
test("Test PILON") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change test name to something more specific, there is no standard (yet) but something like pilon - bam - paired
should do
) | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the module has multiple modes, is it possible to add tests for the others? And a stub test as well, although I see the module currently lacks a stub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some new info on test files
process { | ||
""" | ||
input[0] = [ [ id:'test', single_end:false ], // meta map | ||
file(params.test_data['homo_sapiens']['genome']['genome_fasta'], checkIfExists: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the new guideline is to use URLs instead of the test_data object, so please change the tests accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I just started so can you point to the guidelines? I found some info (but not technical details) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to #5281 for an example, I believe it's not documented yet, but the documentation team is working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to the test-data path is not required currently, just optional.
Please add a stub and test for the stub as mentioned by @itrujnara |
replaced pytest with nf-test for pilon