Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsampling_scheme min-date and max-date don't work #887

Open
abattenhouse opened this issue Mar 13, 2022 · 1 comment
Open

subsampling_scheme min-date and max-date don't work #887

abattenhouse opened this issue Mar 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@abattenhouse
Copy link

Supplying a min-date or max-date subsampling_scheme value results in an error. I ran into this when attempting to subsample with a min-date using Nextstrain code downloaded 2/21/2022.

I fixed the problem in my local code and have created a pull request with my 4-line proposed solution. See:
"Fix subsampling_scheme min-date and max-date parameters bug. #886"

@abattenhouse abattenhouse added the bug Something isn't working label Mar 13, 2022
@jameshadfield
Copy link
Member

@abattenhouse can you try using the following format in the YAML

# Subsampling parameters
subsampling:
  your_scheme_name:
    your_sample_name:
      min_date: "--min-date 2000-01-01"
      max_date: "--max-date 2002-01-01"

Similar issue: #644 (comment)
Reference docs: https://github.com/nextstrain/ncov/blob/master/docs/src/reference/configuration.md#min_date-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: In Review
Development

No branches or pull requests

2 participants