Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update funannotate-p2g.py for contig_expand to use int #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

photocyte
Copy link
Contributor

Mea culpa, I didn't actually test my previous PR until just now, and immediately ran into this rookie mistake. This PR fixes it.

I've also run into some other bugs in funannotate-p2g.py with issues if you have a colon : in the FASTA record id for the protein queries. Will try to work on a PR to report / correct for that edge case as well.

Can I get a brief pointer on how you are implemented tests in this repo? I've never actually done tests, but, figure it is time to learn as formal unit tests would have caught my rookie mistake :)

conda_env_linux-64/lib/python3.9/site-packages/funannotate/aux_scripts/funannotate-p2g.py", line 309, in <module>
    start = x[1] - args.contig_expand
TypeError: unsupported operand type(s) for -: 'int' and 'str'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant