New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blobs-migrate
recipe
#6418
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5ff2f5f
feat: add `blobs-migrate` recipe
eduardoboucas d19ea1a
chore: update `@netlify/blobs`
eduardoboucas 62e71db
refactor: check for delete errors
eduardoboucas 2b42562
chore: fix test
eduardoboucas 5325781
chore: simplify test
eduardoboucas d5b801e
chore: update snapshot
eduardoboucas b0572b1
chore: pin version
eduardoboucas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,18 @@ import { getRecipe, listRecipes } from './common.js' | |
|
||
const SUGGESTION_TIMEOUT = 1e4 | ||
|
||
// @ts-expect-error TS(7031) FIXME: Binding element 'config' implicitly has an 'any' t... Remove this comment to see the full error message | ||
export const runRecipe = async ({ config, recipeName, repositoryRoot }) => { | ||
interface RunRecipeOptions { | ||
args: string[] | ||
command?: BaseCommand | ||
config: unknown | ||
recipeName: string | ||
repositoryRoot: string | ||
} | ||
|
||
export const runRecipe = async ({ args, command, config, recipeName, repositoryRoot }: RunRecipeOptions) => { | ||
const recipe = await getRecipe(recipeName) | ||
|
||
return recipe.run({ config, repositoryRoot }) | ||
return recipe.run({ args, command, config, repositoryRoot }) | ||
} | ||
|
||
export const recipesCommand = async (recipeName: string, options: OptionValues, command: BaseCommand): Promise<any> => { | ||
|
@@ -26,8 +33,10 @@ export const recipesCommand = async (recipeName: string, options: OptionValues, | |
return command.help() | ||
} | ||
|
||
const args = command.args.slice(1) | ||
|
||
try { | ||
return await runRecipe({ config, recipeName: sanitizedRecipeName, repositoryRoot }) | ||
return await runRecipe({ args, command, config, recipeName: sanitizedRecipeName, repositoryRoot }) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were previously not passing the command arguments to recipes, but it's useful when a recipe needs to take input from the user. |
||
} catch (error) { | ||
if ( | ||
// The ESM loader throws this instead of MODULE_NOT_FOUND | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this the only dependency with a caret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We're pinning the exact versions of dependencies to avoid issues with transitive dependencies. It shouldn't be an issue here, since
@netlify/blobs
doesn't have any dependencies, but I've pinned it anyway in b0572b1.