feat: add blobs-migrate recipe
#6418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Mar 7, 2024
| try { | ||
| return await runRecipe({ config, recipeName: sanitizedRecipeName, repositoryRoot }) | ||
| return await runRecipe({ args, command, config, recipeName: sanitizedRecipeName, repositoryRoot }) |
There was a problem hiding this comment.
We were previously not passing the command arguments to recipes, but it's useful when a recipe needs to take input from the user.
mraerino
reviewed
Mar 7, 2024
package.json
Outdated
| @@ -72,7 +72,7 @@ | |||
| "dependencies": { | |||
| "@bugsnag/js": "7.20.2", | |||
| "@fastify/static": "6.10.2", | |||
| "@netlify/blobs": "6.5.0", | |||
| "@netlify/blobs": "^7.0.0", | |||
There was a problem hiding this comment.
why is this the only dependency with a caret?
There was a problem hiding this comment.
Good catch! We're pinning the exact versions of dependencies to avoid issues with transitive dependencies. It shouldn't be an issue here, since @netlify/blobs doesn't have any dependencies, but I've pinned it anyway in b0572b1.
| ...clientOptions, | ||
| name: storeName, | ||
| }) | ||
| const { blobs } = await oldStore.list() |
There was a problem hiding this comment.
does this really return all blobs? no pagination?
There was a problem hiding this comment.
mraerino
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
blobs-migraterecipe that lets folks migrate a Netlify Blobs store as they update to version 7.0.0 of@netlify/blobs.Keeping this as draft until netlify/blobs#148 is merged and the
@netlify/blobsdependency is updated.Part of ADN-370.