Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(microservices): fix redundant code to emit error" #13367

Merged
merged 1 commit into from Mar 27, 2024
Merged

Revert "fix(microservices): fix redundant code to emit error" #13367

merged 1 commit into from Mar 27, 2024

Conversation

kamilmysliwiec
Copy link
Member

Reverts #13328

@kamilmysliwiec kamilmysliwiec merged commit 872ab40 into master Mar 27, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the revert-13328-fix/redundant-emit-code branch March 27, 2024 07:34
@kamilmysliwiec kamilmysliwiec mentioned this pull request Mar 27, 2024
Closed
2 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 846512ad-0ace-460f-9699-db8973122bac

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.125%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-grpc.ts 6 8 75.0%
Totals Coverage Status
Change from base Build b41ad400-7d26-483f-b16f-c94b0a88503b: -0.02%
Covered Lines: 6738
Relevant Lines: 7314
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: microservices type: bug 😭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilmysliwiec @coveralls