gRPC Streaming endpoints that throw errors crash the main process

[ssilve1989]

Did you read the migration guide?

• I have read the whole migration guide

Is there an existing issue that is already proposing this?

• I have searched the existing issues

Potential Commit/PR that introduced the regression

#13328

NestJS version

10.2.9 -> 10.3.5

Describe the regression

gRPC server streaming endpoints that throw errors now have nothing catching those errors resulting in an unhandledRejection crashing the application. This is the offending PR #13328

I will plan to work with @benlesh to get a PR up to resolve these as well as some other concerns ben has around the call.emit changes, and add test cases that prevent this issue in the future

Minimum reproduction code

https://github.com/ssilve1989/nest-grpc-streaming-regression

Input code

A simple rpc that throws an error crashes the entire application now

  @GrpcMethod('EchoService', 'StreamEcho')
  streamEcho(request: StreamEchoRequest): Observable<StreamEchoResponse> {
    throw new Error('oopsies');
  }

Expected behavior

The server responding to requests with gRPC Errors should not itself crash.

Other

papertrail of PRs that led to this issue

#12673
#13195
#13328

[kamilmysliwiec]

Thank you @ssilve1989! For now I just reverted the #13328 PR #13367

[ssilve1989]

Made the updates here: #13368 I couldn't think of a great commit message given the constraints of commitlint so happy to change it to whatever you want