New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document struct field names in stream.go #5359
Conversation
5760bf3
to
675e1cb
Compare
Thank you for doing this! As someone external to the Nats Core team who code reviews every PR acquiring knowledge, this is really valuable. I wish the codebase had become more verbose in terms of spelling names and introduced even more types to reflect the domain as well 🙏🏻 Regardless, this is super valuable! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, one minor correction needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @jnmoyne can you rebase on top of main and resolve one conflict with your sourcing change? |
Once resolved I will pull in. |
…improve the code accessibility. Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Rebased |
- Add comments to document main structure field names a bit better and improve the code accessibility. - Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
- Add comments to document main structure field names a bit better and improve the code accessibility. - Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne jnmoyne@gmail.com