Cherry-pick PRs for 2.10.15-RC.5 #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resets the stalling detection timestamp upon re-creating the consumer - Adjust the idle heart beat for source/mirror consumers from 1s to 5s --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
- Add comments to document main structure field names a bit better and improve the code accessibility. - Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…orConsumer (#5369) Move cancelMirrorConsumer call inside the locked section in retryMirrorConsumer Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
changed the title
…t and discard new. - Avoids re-scanning the stream to find the consumer's starting sequence number for that source every time. Do not log a warning every time this happens as it becomes constant log spam for something that happens temporarily all the time. - Strengthen test TestJetStreamClusterSourceWorkingQueueWithLimit to also check the payload (to catch for example the same message being sourced more than once, or messages not getting sourced). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…che expiration logic. Also added in additional filestore config to control this if needed, still defaults to 10s. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: