Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Fix for why Open MCT goes blank sometimes #7649

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions e2e/tests/mobile/smoke.e2e.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,13 @@ test.describe('Smoke tests for @mobile', () => {
await expect(await page.getByLabel('Child Layout 1 Layout')).toBeVisible();
expect(await page.getByLabel('Child Layout 2 Layout').count()).toBe(0);
});
test.fixme(
'Ensure that the names of folders are very long are truncated and that the folder action buttons are visible',
async ({ page }) => {
test.info().annotations.push({
type: 'issue',
description: 'https://github.com/nasa/openmct/issues/7320'
});
}
);
});
4 changes: 4 additions & 0 deletions src/plugins/folderView/components/grid-view.scss
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@
display: flex;
flex-flow: column nowrap;
flex: 1 1 auto;

body.mobile & {
width: 0;
}
}

&__name {
Expand Down
2 changes: 1 addition & 1 deletion src/styles/_constants-mobile.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ $mobileOverlayMargin: 20px;
$mobileMenuIconD: 25px;
$phoneItemH: floor(math.div($gridItemMobile, 4));
$tabletItemH: floor(math.div($gridItemMobile, 3));
$shellTimeConductorMobileH: 90px;
$shellTimeConductorMobileH: 30px;

/************************** MOBILE TREE MENU DIMENSIONS */
$mobileTreeItemH: 35px;
Expand Down
6 changes: 0 additions & 6 deletions src/ui/layout/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@
bottom: $shellTimeConductorH + $interiorMargin;
}

@include phonePortrait() {
.l-shell__main-container {
bottom: $shellTimeConductorMobileH + $interiorMargin;
}
}

.l-shell__time-conductor {
bottom: 0;
}
Expand Down
5 changes: 5 additions & 0 deletions src/ui/layout/pane.scss
Original file line number Diff line number Diff line change
Expand Up @@ -360,4 +360,9 @@
}
}
} // Ends .body.desktop
body.mobile & {
.l-pane__expand-button {
display: none;
}
}
} // Ends .l-pane