Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Fix for why Open MCT goes blank sometimes #7649

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Mar 27, 2024

Closes #7320

Describe your changes:

  • hides problematic class that addresses this original issue
  • also expands the main pane's height to take up the entirety of the device height
  • MISC Changes as well: (1) I found a small issue where folders with long names do not wrap properly in mobile. Its a small fix that's not worth filing a separate issue for
Screenshot 2024-03-28 at 9 51 25 AM

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (f98eb31) to head (713b969).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7649      +/-   ##
==========================================
- Coverage   49.13%   49.11%   -0.03%     
==========================================
  Files         671      671              
  Lines       27116    27116              
  Branches     2632     2632              
==========================================
- Hits        13324    13318       -6     
- Misses      13464    13470       +6     
  Partials      328      328              
Flag Coverage Δ
e2e-full ?
unit 49.11% <ø> (-0.03%) ⬇️

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98eb31...713b969. Read the comment docs.

@rukmini-bose rukmini-bose marked this pull request as ready for review April 1, 2024 20:54
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting width: 0 on the grid item details element (line 111, grid-view.scss) to fix the text overwriting problem is not the way to solve this. Instead, the __details class needs to have overflow: hidden on it. This then allows the ellipsizing that's applied to the __name div inside to work properly. I tested, and you can just add the overflow property to the base CSS for __details - it doesn't need to be mobile-only.

Everything else looks great, good to go with the correction above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants