Postbit — For #2972 #2988

WildcardSearch · 2018-01-14T18:37:24Z

Main templates:

postbit -> removed
posbit_classic -> postbit/postbit.twig

Sub templates:

Suggestions/reviews welcome.

[WIP]

euantorano · 2018-01-14T18:48:14Z

I believe @justinsoltesz and @Eric-Jackson are talking about removing the horizontal postbit (postbit), so it's probably not worth translating that one - just do postbit_classic, but name it as postbit and always render that template. We'll have to remove the option from the user CP options too.

WildcardSearch · 2018-01-14T18:51:08Z

Will do.

euantorano · 2018-01-14T18:50:07Z

inc/views/base/postbit/postbit.twig

+				</span>
+		</div>
+		<div class="author_statistics">
+			{{ post.user_details|raw }}


Might be worth moving the content of the user details template inline, since the plan is to have one postbit template.

euantorano · 2018-01-14T18:51:01Z

inc/views/base/postbit/postbit.twig

+	</div>
+	<div class="post_controls">
+		<div class="postbit_buttons author_buttons float_left">
+			{{ post.button_email|raw }}{{ post.button_pm|raw }}{{ post.button_www|raw }}{{ post.button_find|raw }}{{ post.button_rep|raw }}


Ouch, lots of raws here. We should probably do the conditions in the template and include other templates for each button.

I don't think there's even a good reason to break out the buttons into separate templates, is there? They will only be used in this template when the postbits are combined.

Having the conditions in the template would be ideal.

This is a WIP. I just did that to get me up and displaying correctly on the new template. The next move is to walk back through the included templates and work them out one at a time.

Justin ninja'd me. I was thinking of passing an array of boolean values to Twig and just if each button. What do you guys think?

That sounds like the best approach to me @WildcardSearch! We also need to make it possible for plugin developers to add new buttons (eg: for likes and such), so we need to think about that. Perhaps we add the template hook functionality I was going to add to 2.0 to 1.9 too?

Yeah, @euantorano, that sounds like a plan.

Trust me, everything I do, I am thinking about how I am going to manipulate these templates in my plugins lol

justinsoltesz · 2018-01-14T18:53:44Z

Correct, we will only have one postbit style in the 1.9 theme.

WildcardSearch · 2018-01-14T19:23:36Z

Updated PR with a list of templates to work through before postbit will be converted fully.

postbit_online, postbit_away. postbit_offline

postbit_author_user, postbit_author_guest

postbit_warninglevel, postbit_warn

justinsoltesz · 2018-01-14T23:48:41Z

Just a general comment after looking at postbit.twig -- the logic should be indented to match the HTML syntax. Makes it easier to read.

postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value

WildcardSearch · 2018-01-15T00:03:57Z

I'm not sure I understand what you mean, @justinsoltesz

justinsoltesz · 2018-01-15T00:05:25Z

Take a look at how the various if statements are indented in this file:

https://github.com/mybb/mybb/blob/develop/1.9/inc/views/base/calendar/calendar.twig

WildcardSearch · 2018-01-15T00:09:10Z

I see what you mean, @justinsoltesz . But in the example you linked, the outputted HTML is not indented correctly, ie.:

mybb/inc/views/base/calendar/calendar.twig

Lines 27 to 30 in d398853

    
           <td class="tcat">&nbsp;</td> 
        
           {% for weekday in weekday_headers %} 
        
               <td class="tcat" align="center" width="14%"><strong>{{ weekday }}</strong></td> 
        
           {% endfor %}

The conditional td is indented too far.

justinsoltesz · 2018-01-15T00:12:32Z

MyBB's output already isn't indented correctly... I think it's better for the template to be easier to read (and subsequently be easier to edit) than have the outputted page source be indented correctly.

WildcardSearch · 2018-01-15T00:15:02Z

Gotcha. I will do a code cleanup when I get all the work done.

postbit_posturl, postbit_inlinecheck

announcement_edit, announcement_quickdelete

postbit_iplogged_show, postbit_iplogged_hiden

postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved

WildcardSearch · 2018-01-17T04:00:48Z

@euantorano and @justinsoltesz, I have things working with the new template system for postbit and code cleaned up as best as I could.

euantorano · 2018-01-17T12:07:45Z

Nice one @WildcardSearch, thanks. I'll have a look and test of this either this week or at the weekend.

justinsoltesz · 2018-01-17T12:48:42Z

inc/views/base/postbit/postbit.twig

+				{% if post.replink %}
+					<br />{{ lang.postbit_reputation }} {{ post.userreputation|raw }}
+				{% endif %}
+				{% for field in post.profile_fields %}


Does this result in all of the profile fields being shown in the postbit? I believe these fields are currently 'optional' -- you can add a variable to include them if you want, but they aren't included by default.

(That said, the 1.9 theme concepts don't have any fields in the postbit...)

Edit: To clarify -- it probably would make sense to break this out in a separate template that can be included if desired, similar to the way it works in 1.8.

@justinsoltesz the profile fields that are to be displayed are loaded before build_postbit is called. In other words, it is a global variable $profile_fields that the calling code would define.

Sorry, you're right. I didn't realize they were automatically added based on a setting in the ACP in 1.8 (they definitely weren't in a previous version).

No problem. I am getting to know this section of code much better than I ever have before. I guess that is another benefit of this conversion as well as some long overdue code cleanup and convention updates.

* Postbit — For #2972 [WIP] * removed horizontal postbit * postbit_groupimage * postbit_userstar * Online Status postbit_online, postbit_away. postbit_offline * postbit_avatar * postbit_find * postbit_pm * postbit_rep_button * postbit_www * postbit_email * User Details postbit_author_user, postbit_author_guest * postbit_reputation * Warning Info postbit_warninglevel, postbit_warn * postbit_purgespammer * Custom Profile Fields postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value * Private Messages postbit_reply_pm, postbit_replyall_pm, postbit_forward_pm, * Edit Message postbit_editedby, postbit_editedby_editreason * Post Edit postbit_editreason, postbit_edit * Quick Delete/Restore postbit_quickdelete, postbit_quickrestore * Post Links/Inline Moderation postbit_posturl, postbit_inlinecheck * postbit_quote * postbit_multiquote * postbit_report * Announcements announcement_edit, announcement_quickdelete * Post IP Display postbit_iplogged_show, postbit_iplogged_hiden * postbit_status * postbit_signature * postbit_icon * postbit_deleted * postbit_ignored * postbit_deleted_member * Attachments postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved * Code Cleanuo * More Code Cleanup

* Postbit — For mybb#2972 [WIP] * removed horizontal postbit * postbit_groupimage * postbit_userstar * Online Status postbit_online, postbit_away. postbit_offline * postbit_avatar * postbit_find * postbit_pm * postbit_rep_button * postbit_www * postbit_email * User Details postbit_author_user, postbit_author_guest * postbit_reputation * Warning Info postbit_warninglevel, postbit_warn * postbit_purgespammer * Custom Profile Fields postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value * Private Messages postbit_reply_pm, postbit_replyall_pm, postbit_forward_pm, * Edit Message postbit_editedby, postbit_editedby_editreason * Post Edit postbit_editreason, postbit_edit * Quick Delete/Restore postbit_quickdelete, postbit_quickrestore * Post Links/Inline Moderation postbit_posturl, postbit_inlinecheck * postbit_quote * postbit_multiquote * postbit_report * Announcements announcement_edit, announcement_quickdelete * Post IP Display postbit_iplogged_show, postbit_iplogged_hiden * postbit_status * postbit_signature * postbit_icon * postbit_deleted * postbit_ignored * postbit_deleted_member * Attachments postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved * Code Cleanuo * More Code Cleanup

* Postbit — For #2972 [WIP] * removed horizontal postbit * postbit_groupimage * postbit_userstar * Online Status postbit_online, postbit_away. postbit_offline * postbit_avatar * postbit_find * postbit_pm * postbit_rep_button * postbit_www * postbit_email * User Details postbit_author_user, postbit_author_guest * postbit_reputation * Warning Info postbit_warninglevel, postbit_warn * postbit_purgespammer * Custom Profile Fields postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value * Private Messages postbit_reply_pm, postbit_replyall_pm, postbit_forward_pm, * Edit Message postbit_editedby, postbit_editedby_editreason * Post Edit postbit_editreason, postbit_edit * Quick Delete/Restore postbit_quickdelete, postbit_quickrestore * Post Links/Inline Moderation postbit_posturl, postbit_inlinecheck * postbit_quote * postbit_multiquote * postbit_report * Announcements announcement_edit, announcement_quickdelete * Post IP Display postbit_iplogged_show, postbit_iplogged_hiden * postbit_status * postbit_signature * postbit_icon * postbit_deleted * postbit_ignored * postbit_deleted_member * Attachments postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved * Code Cleanuo * More Code Cleanup

Postbit — For #2972

65bab4a

[WIP]

euantorano reviewed Jan 14, 2018

View reviewed changes

removed horizontal postbit

eb05636

postbit_groupimage

d91f6a8

euantorano added t:enhancement Type: Enhancement. Contains minor improvements s:in-progress Status: In Progress. Some work completed b:1.9 Branch: 1.9.x labels Jan 14, 2018

Mark Vincent added 12 commits January 14, 2018 14:13

postbit_userstar

6c7fa4d

Online Status

895e418

postbit_online, postbit_away. postbit_offline

postbit_avatar

939a050

postbit_find

2623b04

postbit_pm

56c8722

postbit_rep_button

953158c

postbit_www

0d1c308

postbit_email

3e277ce

User Details

80d0040

postbit_author_user, postbit_author_guest

postbit_reputation

fcb7131

Warning Info

cc05a23

postbit_warninglevel, postbit_warn

postbit_purgespammer

68f46e5

Custom Profile Fields

1d874b6

postbit_profilefield, postbit_profilefield_multiselect, postbit_profilefield_multiselect_value

Mark Vincent added 14 commits January 14, 2018 21:00

Post Links/Inline Moderation

2f5d742

postbit_posturl, postbit_inlinecheck

postbit_quote

f2e14b1

postbit_multiquote

b3416dc

postbit_report

8583e1d

Announcements

71532d4

announcement_edit, announcement_quickdelete

Post IP Display

f30732d

postbit_iplogged_show, postbit_iplogged_hiden

postbit_status

378fe13

postbit_signature

2d29b29

postbit_icon

c7a7b63

postbit_deleted

933cccb

postbit_ignored

129f17b

postbit_deleted_member

5041aaa

Attachments

e983156

postbit_attachments, postbit_attachments_thumbnails, postbit_attachments_thumbnails_thumbnail, postbit_attachments_images, postbit_attachments_images_image, postbit_attachments_attachment, postbit_attachments_attachment_unapproved

Code Cleanuo

1892362

justinsoltesz reviewed Jan 17, 2018

View reviewed changes

More Code Cleanup

4562b49

andrewjs18 requested a review from kawaii January 29, 2018 14:10

WildcardSearch removed the s:in-progress Status: In Progress. Some work completed label Feb 3, 2018

Starpaul20 mentioned this pull request Feb 6, 2018

Working on #2972 Template Conversion to Twig Format (portal.php) #3019

Merged

euantorano merged commit 7267bb2 into mybb:develop/1.9 Feb 16, 2018

WildcardSearch deleted the fix-2972-postbit branch February 16, 2019 13:12

euantorano mentioned this pull request Jan 4, 2020

Develop/1.9 #3857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postbit — For #2972 #2988

Postbit — For #2972 #2988

WildcardSearch commented Jan 14, 2018 •

edited

euantorano commented Jan 14, 2018

WildcardSearch commented Jan 14, 2018

euantorano Jan 14, 2018 •

edited

WildcardSearch Jan 14, 2018

euantorano Jan 14, 2018

justinsoltesz Jan 14, 2018

WildcardSearch Jan 14, 2018

WildcardSearch Jan 14, 2018

euantorano Jan 14, 2018 •

edited

WildcardSearch Jan 14, 2018

justinsoltesz commented Jan 14, 2018

WildcardSearch commented Jan 14, 2018 •

edited

justinsoltesz commented Jan 14, 2018

WildcardSearch commented Jan 15, 2018

justinsoltesz commented Jan 15, 2018

WildcardSearch commented Jan 15, 2018

justinsoltesz commented Jan 15, 2018

WildcardSearch commented Jan 15, 2018

WildcardSearch commented Jan 17, 2018

euantorano commented Jan 17, 2018 •

edited

justinsoltesz Jan 17, 2018 •

edited

WildcardSearch Jan 17, 2018

justinsoltesz Jan 17, 2018

WildcardSearch Jan 17, 2018

Postbit — For #2972 #2988

Postbit — For #2972 #2988

Conversation

WildcardSearch commented Jan 14, 2018 • edited

euantorano commented Jan 14, 2018

WildcardSearch commented Jan 14, 2018

euantorano Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

euantorano Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinsoltesz commented Jan 14, 2018

WildcardSearch commented Jan 14, 2018 • edited

justinsoltesz commented Jan 14, 2018

WildcardSearch commented Jan 15, 2018

justinsoltesz commented Jan 15, 2018

WildcardSearch commented Jan 15, 2018

justinsoltesz commented Jan 15, 2018

WildcardSearch commented Jan 15, 2018

WildcardSearch commented Jan 17, 2018

euantorano commented Jan 17, 2018 • edited

justinsoltesz Jan 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WildcardSearch commented Jan 14, 2018 •

edited

euantorano Jan 14, 2018 •

edited

euantorano Jan 14, 2018 •

edited

WildcardSearch commented Jan 14, 2018 •

edited

euantorano commented Jan 17, 2018 •

edited

justinsoltesz Jan 17, 2018 •

edited