Working on #2972 Template Conversion to Twig Format (portal.php) #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is finished |
euantorano
requested changes
Feb 16, 2018
inc/views/base/portal/portal.twig
Outdated
| {% block head %} | ||
| <title>{{ mybb.settings.bbname }}</title> | ||
| <link rel="alternate" type="application/rss+xml" title="{{ lang.latest_announcements }} (RSS 2.0)" href="{{ mybb.settings.bburl }}/syndication.php?portal=1" /> | ||
| <link rel="alternate" type="application/atom+xml" title="{{ lang.latest_announcements }} (Atom 1.0)" href="{{ mybb.settings.bburl }}/syndication.php?portal=1&type=atom1.0" /> |
inc/views/base/portal/portal.twig
Outdated
| </tr> | ||
| <tr> | ||
| <td class="trow1"> | ||
| <span class="smalltext">{{ lang.pms_received_new|raw }}<br /><br /> |
There was a problem hiding this comment.
Rather than using |raw here, it looks like this is a fairly simple language variable that could be built in the template using the trans() function. One of my PRs from today marks the trans() function as being HTML safe, so as long as $mybb->user['username'] is HTML safe, it should be fine here.
|
Done |
euantorano
approved these changes
Feb 16, 2018
|
Would you mind updating the list of templates in #2972 with the ones you've finished with the PRs I've merged too please? |
euantorano
pushed a commit
that referenced
this pull request
Mar 16, 2018
* Working on #2972 Template Conversion to Twig Format (portal.php) * Updated attachments * Coding standards
euantorano
pushed a commit
that referenced
this pull request
Jun 2, 2019
* Working on #2972 Template Conversion to Twig Format (portal.php) * Updated attachments * Coding standards
euantorano
pushed a commit
that referenced
this pull request
Jun 2, 2019
* Working on #2972 Template Conversion to Twig Format (portal.php) * Updated attachments * Coding standards
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2972 for portal.php
This is still incomplete, I need #2988 merged before I can finish this.