sovereign extra header verifier in runtype components #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor-sov-runtype-comp-16 # Conflicts: # factory/runType/sovereignRunTypeComponents.go # testscommon/components/components.go
…factor-sov-runtype-comp-16 # Conflicts: # testscommon/components/components.go
| @@ -202,7 +196,11 @@ func (rcf *sovereignRunTypeComponentsFactory) Create() (*runTypeComponents, erro | |||
|
|
|||
| expiryTime := time.Second * time.Duration(rcf.sovConfig.OutgoingSubscribedEvents.TimeToWaitForUnconfirmedOutGoingOperationInSeconds) | |||
|
|
|||
| err = rtc.extraHeaderSigVerifierHandler.RegisterExtraHeaderSigVerifier(rcf.extraVerifier) | |||
| sovHeaderSigVerifier, err := headerCheck.NewSovereignHeaderSigVerifier(rcf.cryptoComponents.BlockSigner()) | |||
There was a problem hiding this comment.
Is this also removed from normal run type ?
There was a problem hiding this comment.
Normal RunType doesn't use an extra header sig verifier, it's just:
extraHeaderSigVerifierHandler: headerCheck.NewExtraHeaderSigVerifierHolder(),
There was a problem hiding this comment.
The name of the variable was wrong and confused me;
extraHeaderSigVerifierHandler -> this is a holder, not a handler, please rename it
…factor-sov-runtype-comp-16
…factor-sov-runtype-comp-16
…factor-sov-runtype-comp-16
mariusmihaic
requested changes
May 10, 2024
| @@ -202,7 +196,11 @@ func (rcf *sovereignRunTypeComponentsFactory) Create() (*runTypeComponents, erro | |||
|
|
|||
| expiryTime := time.Second * time.Duration(rcf.sovConfig.OutgoingSubscribedEvents.TimeToWaitForUnconfirmedOutGoingOperationInSeconds) | |||
|
|
|||
| err = rtc.extraHeaderSigVerifierHandler.RegisterExtraHeaderSigVerifier(rcf.extraVerifier) | |||
| sovHeaderSigVerifier, err := headerCheck.NewSovereignHeaderSigVerifier(rcf.cryptoComponents.BlockSigner()) | |||
There was a problem hiding this comment.
The name of the variable was wrong and confused me;
extraHeaderSigVerifierHandler -> this is a holder, not a handler, please rename it
mariusmihaic
requested changes
May 13, 2024
| @@ -544,16 +544,16 @@ func (mrc *managedRunTypeComponents) TxPreProcessorCreator() preprocess.TxPrePro | |||
| return mrc.runTypeComponents.txPreProcessorCreator | |||
| } | |||
|
|
|||
| // ExtraHeaderSigVerifierHandler returns the extra header sig verifier handler | |||
| func (mrc *managedRunTypeComponents) ExtraHeaderSigVerifierHandler() headerCheck.ExtraHeaderSigVerifierHolder { | |||
| // ExtraHeaderSigVerifierHolder returns the extra header sig verifier handler | |||
There was a problem hiding this comment.
Suggested change
| // ExtraHeaderSigVerifierHolder returns the extra header sig verifier handler | |
| // ExtraHeaderSigVerifierHolder returns the extra header sig verifier holder |
Base automatically changed from
MX-15315-refactor-sov-runtype-comp-14
to
feat/refactor-runtype-components
May 13, 2024 08:09
…r-sov-runtype-comp-16
mariusmihaic
approved these changes
May 13, 2024
raduchis
approved these changes
May 13, 2024
axenteoctavian
merged commit 3552ab2
into
feat/refactor-runtype-components
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?