refactor ExtraHeaderSigVerifierHolder #6097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor-sov-runtype-comp-10 # Conflicts: # factory/processing/processComponents_test.go
…actor-sov-runtype-comp-10 # Conflicts: # cmd/sovereignnode/sovereignNodeRunner.go # factory/runType/runTypeComponents.go # factory/runType/sovereignRunTypeComponents.go # factory/runType/sovereignRunTypeComponents_test.go # genesis/process/sovereignGenesisBlockCreator_test.go # testscommon/components/components.go # testscommon/mainFactoryMocks/runTypeComponentStub.go
…mp-10' into MX-15315-refactor-sov-runtype-comp-10
sasurobert
previously approved these changes
Apr 22, 2024
mariusmihaic
requested changes
Apr 24, 2024
…actor-sov-runtype-comp-10 # Conflicts: # factory/runType/sovereignRunTypeComponents.go
mariusmihaic
previously approved these changes
Apr 26, 2024
Base automatically changed from
MX-15315-refactor-sov-runtype-comp-9
to
feat/refactor-runtype-components
April 26, 2024 09:32
axenteoctavian
dismissed stale reviews from mariusmihaic and sasurobert
The base branch was changed.
…r-sov-runtype-comp-10
mariusmihaic
approved these changes
Apr 26, 2024
sasurobert
approved these changes
Apr 26, 2024
axenteoctavian
merged commit c66de4f
into
feat/refactor-runtype-components
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
ExtraHeaderSigVerifierHolderProposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?