-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make specularGlossiness inherit from MeshStandardMaterial #18474
Conversation
examples/js/loaders/GLTFLoader.js
Outdated
}, | ||
specularMap: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor indentation issue.
Thanks! |
I think I need envoys for my PRs, when my name is directly behind them they tend to get stuck :) I cleaned it up 6-7 times, but oh well, hopefully one of these days I’ll get some git blame. |
Try submitting your next PR with a different username 😝 |
Looks like the way to go :) |
Fixes #18463
I've just taken #14099 by @pailhead and fixed the conflicts to update it. I made only a couple of minor fixes of my own that you can see in the last commit. This replaces my first failed effort at fixing this problem in #18465; the approach from this old PR both fixes the problem and also cleans up the code nicely. It also makes it unnecessary to delve into the gltf.parser.extensions to allow this material to be cloned; it just happens automatically!