New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch to zoom [WIP] #3708
Pinch to zoom [WIP] #3708
Conversation
@timvandermeij Nice that you're making progress! One other idea: Instead of adding a lot of code in |
@Snuffleupagus I have made the changes you proposed in this new commit, thanks! That also resolves Travis' issues. |
@@ -77,6 +78,7 @@ var mozL10n = document.mozL10n || document.webL10n; | |||
var cache = new Cache(CACHE_SIZE); | |||
var currentPageNumber = 1; | |||
|
|||
//#include ../external/hammer.js/hammer.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest moving this line to touch_events.js
instead.
I assume that this would require something like a re-implementation of #3513. I've actually taken a stab at this again, but it still requires more testing before I'll consider submitting it again. |
Rebased. No code changes were made. |
I'm closing this. The implementation is far from stable and unfortunately I cannot put a lot of time in this feature right now. The original issue is still open so we won't forget about this feature. |
This PR implements pinch to zoom functionality as described in #2582.
Things left to do: