New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor `SimpleLinkService` to extend `PDFLinkService` #18013

Merged

timvandermeij merged 1 commit into mozilla:master from Snuffleupagus:SimpleLinkService-extends-PDFLinkService

Apr 29, 2024

Commits on Apr 28, 2024

Re-factor SimpleLinkService to extend PDFLinkService

Rather than having to maintain a dummy `IPDFLinkService` implementation, we can simply let it extend the primary `PDFLinkService` class instead.
Note how *some* methods already checked for an active PDF document, and those checks only needed to be used consistently throughout `PDFLinkService` in order for this to work.

Snuffleupagus committed Apr 28, 2024