Re-factor SimpleLinkService to extend PDFLinkService
#18013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having to maintain a dummy `IPDFLinkService` implementation, we can simply let it extend the primary `PDFLinkService` class instead. Note how *some* methods already checked for an active PDF document, and those checks only needed to be used consistently throughout `PDFLinkService` in order for this to work.
Snuffleupagus
commented
Apr 28, 2024
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ba7629f70ec1f21/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/07ca286fbb1011b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ba7629f70ec1f21/output.txt Total script time: 7.41 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/07ca286fbb1011b/output.txt Total script time: 20.02 mins
|
timvandermeij
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having to maintain a dummy
IPDFLinkServiceimplementation, we can simply let it extend the primaryPDFLinkServiceclass instead.Note how some methods already checked for an active PDF document, and those checks only needed to be used consistently throughout
PDFLinkServicein order for this to work.