Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor badge.displayBrowserActionBadge to be used in both popup.js and messageHandler.js #973

Open
groovecoder opened this issue Nov 16, 2017 · 12 comments · May be fixed by #1561
Open

Refactor badge.displayBrowserActionBadge to be used in both popup.js and messageHandler.js #973

groovecoder opened this issue Nov 16, 2017 · 12 comments · May be fixed by #1561
Assignees
Labels
👍 Feature Request Feature requests users would like to see in this addon

Comments

@groovecoder
Copy link
Member

See #921 (comment) for details.

@hritvi
Copy link
Contributor

hritvi commented Sep 19, 2018

May I work on this if it is still open? Thanks 🙂

@groovecoder
Copy link
Member Author

Yes, you're welcome to work on it if you like. I haven't had time to triage or review many PRs though, so if you submit a PR see if you can make it small/concise? Thanks!

@hritvi
Copy link
Contributor

hritvi commented Sep 20, 2018

While doing the initial setup using npm. A warning occurred:

found 20 vulnerabilities (3 low, 14 moderate, 2 high, 1 critical)

I suppose many packages need to be upgraded.
May I file a new issue for this and fix it?

@groovecoder
Copy link
Member Author

Yes, a new issue for that would be good. Thanks.

@Aishat-Akinyemi
Copy link

Aishat-Akinyemi commented Oct 2, 2019

Hello @groovecoder I am a 2019 Outreachy applicant, May I work on this as my first contribution? Thank you.

@groovecoder
Copy link
Member Author

Hi @Aishat-Akinyemi - yes you can pick this one up.

@groovecoder groovecoder self-assigned this Oct 3, 2019
@groovecoder
Copy link
Member Author

I'm assigning this to myself to mark it as being assigned. Please let me know if you decide to work on a different issue.

@Aishat-Akinyemi
Copy link

I will start working on it, thank you.

@Aishat-Akinyemi
Copy link

I have submitted a Pull request that fixes this issue [https://github.com//pull/1523#issue-326806982]

@maxxcrawford
Copy link
Collaborator

@Aishat-Akinyemi Can you open up a PR for us to review?

@Aishat-Akinyemi
Copy link

Aishat-Akinyemi commented Oct 16, 2019

@

@Aishat-Akinyemi Can you open up a PR for us to review?

@maxxcrawford I already opened up a PR #1523 that fixes this issue and issue #1513 . You commented on it saying I should make some changes. I have made those changes as requested, kindly check the PR #1523 .

Or should I make a new PR from scratch, kindly advise, thank you.

@maxxcrawford
Copy link
Collaborator

@Aishat-Akinyemi Nope – This works! I'll review. Thank you! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment