Refactors badge.displayBrowserActionBadge

[hritvi]

Fixes #973
Refactors badge.displayBrowserActionBadge to be used in both popup.js and messageHandler.js

[jonathanKingston]

@hritvi so it looks like you have some linting errors could you fix those please? https://travis-ci.org/mozilla/multi-account-containers/builds/435588288?utm_source=github_status&utm_medium=notification

[hritvi]

@jonathanKingston I have made the required changes. Please review 🙂

[jonathanKingston]

@hritvi When running the code I am getting the following error in the browser toolbox:

TypeError: background.backgroundLogic is undefined[Learn More] popup.js:157:11

It looks like you are using a const at the top of the function to a string rather than importing the code into the popup. Take a look at the other areas where we share code, we are usually using browser.runtime.sendMessage which sends over a message to the background script where the actual work is done.

[groovecoder]

Thank you for your previous contributions to Multi-Account Containers. We're closing PRs with conflicts to prepare this repo for some work in the near future. If you would like to re-submit the changes in a branch from the latest master code, we would love to take another look at this!