feat: add game back menu #1171
feat: add game back menu #1171
Conversation
|
Nice PR. Hope this PR will be merged to master soon. The other idea is that you may consider to add Ctrl + V button to support pasting from clipboard too. It's very useful for chatting in games. |
app/src/main/java/com/limelight/computers/ComputerDatabaseManager.java
Outdated
Show resolved
Hide resolved
kmreisi
force-pushed
the
back_menu
branch
2 times, most recently
from
29f1613
to
dcbc4ac
Compare
kmreisi
force-pushed
the
back_menu
branch
3 times, most recently
from
7c71b57
to
e195957
Compare
|
I added a Toggle Keyboard option to the generic game menu.
and the Mouse emulation selection to the game menu when launched from a controller Now the game menu can show controller specific options. Alternatively we could always show the mouse emulation toggle and apply the change to all controllers. |
|
@cgutman please have a look :-) |
|
Sorry for the delays reviewing this. I will try to take a look by this weekend. |
kmreisi
force-pushed
the
back_menu
branch
3 times, most recently
from
c062745
to
84dc834
Compare
Add back menu to send sepcial keys. E.g. close fullscreen while using yuzu.
Changes: * Include toggle keyboard action in game menu * Add generic game input device abstraction (which can be implemented by all kind of input devices) * Show input device game menu options * Implement for controller to provide mouse emulation selection
Changes: * Add withGameFocus option to game menu option to run the given runnable after alert dialog has been closed and the game has focus again. * use game focus option for on screen keyboard and toogle mouse
|
@cgutman this is working for me since a while now :-) Could you give it a try? I tested it using my Odin, Android TV emulator, Pixel 7... Thanks :-) |
|
@cgutman any updates on this PR? :D |
|
I don't think I want to merge it for v12.0, but I haven't forgotten about it. With the latest Sunshine protocol extensions, we can now send native multitouch input to the host. The trouble is that sending every touch natively to the host means that our 3 finger tap gesture no longer works to open the keyboard (or the gesture conflicts with legitimate input). This PR solves that issue quite nicely, so I plan to merge it for v12.1/v13.0 when we enable native touch passthrough. |
|
Is that possible to add a command to send the |
Would be extremely useful for Nvidia Shield TV since it overwrites Guide button on gamepads to always show Android TV home screen at the system level. |
When I posted this, I have made a draft code to do this and worked great. If @kmreisi agrees I can help him. Or maybe we can wait till this one gets merged and open another PR. I used for running on my device and worked pretty great |
@mattvgm feel free to put a commit on top / share your draft so I can cherry-pick your change... I'm using this PR since a long while since it allows me to close Yuzu ;-). Having the Guide button would be practical as well. :-) @cgutman anything I can do to improve this PR to simplify the merge ? ;-) |
|
Hello, it's possible to have apk with last with updated code v12.1 ? Thanks :) |
|
On the topic of the guide button, sunshine now supports registering a long press of the back button to trigger guide. Which I've found very useful. |
Adds a very simple menu on "back" action while streaming.
The menu prevents from accidentally disconnecting and allows to send key events which are handy for game streaming and can not be send through the android keyboard, e.g. Exit full screen with F11 / ESC.